Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Import contacts" button shows in navigation when a team is selected #4090

Open
jancborchardt opened this issue Aug 20, 2024 · 0 comments · May be fixed by #4236
Open

"Import contacts" button shows in navigation when a team is selected #4090

jancborchardt opened this issue Aug 20, 2024 · 0 comments · May be fixed by #4236
Assignees
@GVodyanov
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: contacts skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills

Comments

@jancborchardt
Copy link
Member

Describe the bug

Meta groups on top: All fine Contact groups: All fine Teams: "Import contacts" button shows
image image image

Steps to reproduce

  1. Go to Contacts
  2. Click on any team
  3. Notice the "Import contacts" button appearing on the top of the navigation

Expected behavior

The button "Import contacts" only shows on emptycontent, and in the settings.

Actual behavior

The button "Import contacts" also shows when a team is selected from the left navigation.

Contact version

6.1.0-alpha.2

Operating system

No response

PHP engine version

None

Web server

None

Database

None

Additional info

No response
@jancborchardt jancborchardt added bug Something isn't working feature: contacts 0. Needs triage skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills labels Aug 20, 2024
@jancborchardt jancborchardt moved this to 👓 Design review in 🖍 Design team Aug 20, 2024
@GVodyanov GVodyanov added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage labels Oct 13, 2024
@GVodyanov GVodyanov self-assigned this Oct 13, 2024
@GVodyanov GVodyanov linked a pull request Dec 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GVodyanov GVodyanov

Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: contacts skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
🖍 Design team
Status: 👓 Design review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add proper routing for circles, removing the import button when not needed nextcloud/contacts
2 participants
@jancborchardt @GVodyanov