Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing a vcf file will skip the NOTE field content after the first comma #3721

Open
milouse opened this issue Nov 27, 2023 · 5 comments
Assignees
Labels
2. developing Work in progress bug Something isn't working feature: contacts feature: import Importing (and exporting)

Comments

@milouse
Copy link

milouse commented Nov 27, 2023

Describe the bug

When trying to import an addressbook, if a contact contains some "NOTE" data containing a comma, the field is only imported up to the first comma.

Steps to reproduce

Given the following vcf file

BEGIN:VCARD
VERSION:3.0
N:Test;Alice;;;
FN:Alice Test
TEL;TYPE=CELL:redacted
NOTE:Some note without comma
END:VCARD
BEGIN:VCARD
VERSION:3.0
N:Test;Bob;;;
FN:Bob Test
TEL;TYPE=CELL:redacted
NOTE:Some note, with comma
END:VCARD
  1. Go to contacts app
  2. Click on Import contacts button
  3. Select previously saved vcf file
  4. Import it

Expected behavior

When looking at Alice Test contact, the Note field should read "Some note without comma"

When looking at Bob Test contact, the Note field should read "Some note, with comma"

Actual behavior

When looking at Alice Test contact, the Note field reads "Some note without comma" ✅

When looking at Bob Test contact, the Note field reads "Some note" ❗

Contact version

5.4.2 on NC 27.1.4

Operating system

Debian 5.10

PHP engine version

Other

Web server

Nginx

Database

MariaDB

Additional info

PHP 8.2.13

Installed as Nextcloud App for YunoHost https://github.com/YunoHost-Apps/nextcloud_ynh/

@DiagonalArg
Copy link

DiagonalArg commented Dec 10, 2023

I get a slightly different result. The "," shows up in Notes rendered as "\,"

See #3736

@hamza221 hamza221 self-assigned this Dec 19, 2023
@hamza221 hamza221 added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage labels Dec 19, 2023
@hamza221 hamza221 moved this to 📄 To do (~10 entries) in 💌 📅 👥 Groupware team Dec 19, 2023
@hamza221 hamza221 moved this from 📄 To do (~10 entries) to 🏗️ In progress in 💌 📅 👥 Groupware team Dec 19, 2023
@hamza221
Copy link
Contributor

hamza221 commented Dec 19, 2023

more info on #3729 and #3736 , I could only reproduce on 5.4

@DiagonalArg
Copy link

DiagonalArg commented Dec 20, 2023

On 5.5.0, in the Notes field, I'm getting quotation marks appearing as "\"", colons appearing as "\:", though commas now seem to be fine.

In the Website field, I'm getting addresses looking like this: "https\\://foo.com" (yes, two slashes).

In the address field, I'm still getting things rendered as here: #3736 (comment)

@DiagonalArg
Copy link

DiagonalArg commented Jan 4, 2024

All issues mentioned in previous post, not repaired in 5.5.1

@joshtrichards joshtrichards added the feature: import Importing (and exporting) label Jan 15, 2024
@bcutter
Copy link

bcutter commented Jul 19, 2024

Status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug Something isn't working feature: contacts feature: import Importing (and exporting)
Projects
Status: 🏗️ In progress
Development

No branches or pull requests

5 participants