Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Bug) - Button alignment mismatching on Custom restore focus scenario - Modal Component Storybook Scenarios #809

Open
jannuk59 opened this issue Apr 6, 2023 · 1 comment
Open

(Bug) - Button alignment mismatching on Custom restore focus scenario - Modal Component Storybook Scenarios #809

jannuk59 opened this issue Apr 6, 2023 · 1 comment
Assignees
@jannuk59
Labels
bug Something isn't working
Milestone
Storybook Enhance...

Comments

@jannuk59
Copy link
Contributor

jannuk59 commented Apr 6, 2023 •
edited
Loading

Button alignment (Open model and Take refocus) mismatching as per the design.
Should be aligned one after another.
Storybook

Image
@jannuk59 jannuk59 added the bug Something isn't working label Apr 6, 2023
@jannuk59 jannuk59 added this to the Storybook Enhancements milestone Apr 6, 2023
@jannuk59 jannuk59 self-assigned this Apr 6, 2023
@jannuk59 jannuk59 moved this to Ready to do in NewsKit Apr 6, 2023
@jannuk59 jannuk59 added this to NewsKit Apr 6, 2023
@jannuk59 jannuk59 moved this from Ready to do to In progress in NewsKit Apr 6, 2023
@jannuk59 jannuk59 changed the title Button alignment Custom restore focus in Modal Component - Storybook Scenarios Button alignment on Custom restore focus scenario - Modal Component Storybook Scenarios Apr 6, 2023
@jannuk59 jannuk59 changed the title Button alignment on Custom restore focus scenario - Modal Component Storybook Scenarios (Bug) - Button alignment on Custom restore focus scenario - Modal Component Storybook Scenarios Apr 6, 2023
@jannuk59 jannuk59 changed the title (Bug) - Button alignment on Custom restore focus scenario - Modal Component Storybook Scenarios (Bug) - Button alignment mismatching on Custom restore focus scenario - Modal Component Storybook Scenarios Apr 6, 2023
@jannuk59 jannuk59 mentioned this issue Apr 6, 2023
Merged
8 tasks
@jannuk59 jannuk59 moved this from In progress to Design review in NewsKit Apr 6, 2023
@GeriReid
Copy link
Contributor

GeriReid commented Apr 6, 2023

Thanks for the fix @jannuk59, you can move this to peer review.

@jannuk59 jannuk59 moved this from Design review to Peer review in NewsKit Apr 6, 2023
@jannuk59 jannuk59 moved this from Peer review to Done in NewsKit Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jannuk59 jannuk59

Labels
bug Something isn't working
Projects
NewsKit
Status: Done
Milestone
Storybook Enhancements
Development

No branches or pull requests
2 participants
@jannuk59 @GeriReid