Skip to content

Commit 4e987d6

Browse files
use envs
Signed-off-by: NikitaSkrynnik <[email protected]>
1 parent 4bd089d commit 4e987d6

File tree

4 files changed

+14
-4
lines changed

4 files changed

+14
-4
lines changed

.github/workflows/ci.yaml

+10-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
interdomain:
2525
runs-on: ubuntu-latest
2626
env:
27-
KUBERNETES_VERSION: ${{ secrets.NSM_KUBERNETES_VERSION }}
27+
KUBERNETES_VERSION: ${{ vars.NSM_KUBERNETES_VERSION }}
2828
steps:
2929
- name: Cancel Previous Runs
3030
uses: styfle/[email protected]
@@ -66,6 +66,7 @@ jobs:
6666

6767
- name: Setup gke
6868
run: |
69+
GKE_K8S_VERSION=$(echo $GKE_K8S_VERSION | cut -c 2-)
6970
scripts/gke/gke-start.sh
7071
env:
7172
GCLOUD_SERVICE_KEY: ${{ secrets.GCLOUD_SERVICE_KEY }}
@@ -74,24 +75,28 @@ jobs:
7475
GKE_CLUSTER_NAME: gke-${{ github.run_id }}-${{ github.run_number }}
7576
GKE_CLUSTER_ZONE: us-central1-a
7677
GKE_CLUSTER_TYPE: n1-standard-2
78+
GKE_K8S_VERSION: ${{ vars.NSM_KUBERNETES_VERSION }}
7779
GKE_CLUSTER_NUM_NODES: 1
7880
KUBECONFIG: /tmp/config1
7981
USE_GKE_GCLOUD_AUTH_PLUGIN: true
8082
working-directory: ${{ github.workspace }}/src/github.com/${{ github.repository }}
8183

8284
- name: Setup aws
8385
run: |
86+
AWS_K8S_VERSION_SHORT=$(echo $AWS_K8S_VERSION | cut -d "." -f 1-2 | cut -c 2-)
8487
scripts/aws/aws-start.sh
8588
env:
8689
KUBECONFIG: /tmp/config2
8790
AWS_REGION: us-east-2
8891
AWS_CLUSTER_NAME: aws-${{ github.run_id }}-${{ github.run_number }}
8992
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
9093
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
94+
AWS_K8S_VERSION: ${{ vars.NSM_KUBERNETES_VERSION }}
9195
working-directory: ${{ github.workspace }}/src/github.com/${{ github.repository }}
9296

9397
- name: Setup aks
9498
run: |
99+
AZURE_K8S_VERSION=$(echo $AZURE_K8S_VERSION | cut -c 2-)
95100
az login --service-principal --username ${AZURE_SERVICE_PRINCIPAL} --password ${AZURE_SERVICE_PRINCIPAL_SECRET} --tenant ${AZURE_TENANT}
96101
scripts/aks/aks-start.sh ${AZURE_RESOURCE_GROUP} ${AZURE_CLUSTER_NAME} ${AZURE_CREDENTIALS_PATH} ${KUBECONFIG}
97102
env:
@@ -100,11 +105,15 @@ jobs:
100105
AZURE_CLUSTER_NAME: aks-${{ github.run_id }}-${{ github.run_number }}
101106
AZURE_SERVICE_PRINCIPAL: ${{ secrets.AZURE_SERVICE_PRINCIPAL }}
102107
AZURE_SERVICE_PRINCIPAL_SECRET: ${{ secrets.AZURE_SERVICE_PRINCIPAL_SECRET }}
108+
AZURE_K8S_VERSION: ${{ vars.NSM_KUBERNETES_VERSION }}
103109
AZURE_TENANT: ${{ secrets.AZURE_TENANT }}
104110
working-directory: ${{ github.workspace }}/src/github.com/${{ github.repository }}
105111

106112
- name: Run interdomain testing
107113
run: |
114+
kubectl version --kubeconfig=$KUBECONFIG1
115+
kubectl version --kubeconfig=$KUBECONFIG2
116+
kubectl version --kubeconfig=$KUBECONFIG3
108117
go test -count 1 -timeout 2h -race -v ./... -parallel 4
109118
env:
110119
KUBECONFIG1: /tmp/config1

scripts/aks/aks-start.sh

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ fi
1111
echo -n "Creating AKS cluster '$AZURE_CLUSTER_NAME'..."
1212
az aks create \
1313
--resource-group "$AZURE_RESOURCE_GROUP" \
14+
--kubernetes-version "$AZURE_K8S_VERSION" \
1415
--name "$AZURE_CLUSTER_NAME" \
1516
--node-count 1 \
1617
--node-vm-size Standard_B2s \

scripts/aws/aws-start.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export IAM_NAME=ebs-csi-controller-sa
66

77
apt-get update && apt-get -y install curl dnsutils
88

9-
curl -LO https://storage.googleapis.com/kubernetes-release/release/v1.23.6/bin/linux/amd64/kubectl
9+
curl -LO https://storage.googleapis.com/kubernetes-release/release/$AWS_K8S_VERSION/bin/linux/amd64/kubectl
1010
chmod +x kubectl
1111
mkdir -p ~/.local/bin
1212
mv ./kubectl ~/.local/bin/kubectl
@@ -22,7 +22,7 @@ curl -o aws-iam-authenticator https://s3.us-west-2.amazonaws.com/amazon-eks/1.21
2222

2323
eksctl create cluster \
2424
--name "${AWS_CLUSTER_NAME}" \
25-
--version 1.27 \
25+
--version "${AWS_K8S_VERSION_SHORT}" \
2626
--nodegroup-name "${AWS_CLUSTER_NAME}-workers" \
2727
--node-type t3.xlarge \
2828
--nodes 1

scripts/gke/gke-start.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
gcloud components install gke-gcloud-auth-plugin
44
gcloud components update
5-
time gcloud container clusters create "${GKE_CLUSTER_NAME}" --project="${GKE_PROJECT_ID}" --machine-type="${GKE_CLUSTER_TYPE}" --num-nodes=1 --zone="${GKE_CLUSTER_ZONE}" -q
5+
time gcloud container clusters create "${GKE_CLUSTER_NAME}" --project="${GKE_PROJECT_ID}" --machine-type="${GKE_CLUSTER_TYPE}" --num-nodes=1 --zone="${GKE_CLUSTER_ZONE}" --cluster-version="${GKE_K8S_VERSION}" -q
66
echo "Writing config to ${KUBECONFIG}"
77
gcloud container clusters get-credentials "${GKE_CLUSTER_NAME}" --project="${GKE_PROJECT_ID}" --zone="${GKE_CLUSTER_ZONE}"
88
kubectl create clusterrolebinding cluster-admin-binding --clusterrole cluster-admin --user "$(gcloud config get-value account)"

0 commit comments

Comments
 (0)