Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace package satori/go.uuid #178

Closed
josselin-c opened this issue Jul 11, 2018 · 7 comments · May be fixed by #202
Closed

Replace package satori/go.uuid #178

josselin-c opened this issue Jul 11, 2018 · 7 comments · May be fixed by #202
Labels
stale

Comments

@josselin-c
Copy link

josselin-c commented Jul 11, 2018 •
edited by bcomnes
Loading

This issue has been opened automaticaly because we think you are using satori/uuid in your code. Unfortunately, satori/uuid has a critical defect where it doesn't generate random UUIDV4s satori/go.uuid#73 and should be replaced as the maintainer has been unresponsive for 5 months with the bug still open. Alternative packages you should consider: https://github.com/google/uuid https://github.com/pborman/uuid
@k1ng440
Copy link

k1ng440 commented Oct 17, 2018

done at #188

@k1ng440
Copy link

k1ng440 commented Oct 19, 2018

Solved.

@rybit
Copy link
Member

rybit commented Oct 19, 2018

So this isn't actually solved. The package (https://github.com/gobuffalo/uuid) we moved to is a fork of the problematic package and archived.

image

@ghost
Copy link

ghost commented Dec 18, 2018

https://github.com/gobuffalo/uuid has removed the .Equal function. I can't compile the current master source, because seems like all mentained uuid versions are incompatible. Or which are you using?

@trestoa
Copy link

trestoa commented Dec 19, 2018

According to satori/go.uuid#90 (comment), https://github.com/gofrs/uuid is the permanent and maintained fork of the module. I was already able to build and run gotrue using this module. I will do some more testing and submit a PR if everything works correctly.

@chris-rock chris-rock mentioned this issue Mar 22, 2019
Open
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in 1 year. It will be closed in 7 days if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale label Apr 24, 2021
@github-actions
Copy link

github-actions bot commented May 1, 2021

This issue was closed because it had no activity for over 1 year.

@github-actions github-actions bot closed this as completed May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update uuid dependency chris-rock/gotrue
4 participants
@rybit @josselin-c @trestoa @k1ng440