Do not transfer Options object to methods

Author: emodric

lib/Form/ContentTypeType.php

@@ -25,7 +25,7 @@ public function configureOptions(OptionsResolver $resolver): void
 
         $resolver->setDefault(
             'choices',
-            fn (Options $options): array => $this->getContentTypes($options),
+            fn (Options $options): array => $this->getContentTypes($options['types']),
         );
 
         $resolver->setDefault('choice_translation_domain', false);
@@ -45,14 +45,15 @@ public function getParent(): string
     /**
      * Returns the allowed content types from Ibexa CMS.
      *
+     * @param array<string, string[]|bool> $configuredGroups
+     *
      * @return array<string, string[]>
      */
-    private function getContentTypes(Options $options): array
+    private function getContentTypes(array $configuredGroups): array
     {
         $allContentTypes = [];
 
         $groups = $this->contentTypeService->loadContentTypeGroups();
-        $configuredGroups = $options['types'];
 
         foreach ($groups as $group) {
             $configuredGroups += [$group->identifier => true];

lib/Form/ObjectStateType.php

@@ -25,7 +25,7 @@ public function configureOptions(OptionsResolver $resolver): void
 
         $resolver->setDefault(
             'choices',
-            fn (Options $options): array => $this->getObjectStates($options),
+            fn (Options $options): array => $this->getObjectStates($options['states']),
         );
 
         $resolver->setDefault('choice_translation_domain', false);
@@ -45,14 +45,15 @@ public function getParent(): string
     /**
      * Returns the allowed content states from Ibexa CMS.
      *
+     * @param array<string, string[]|bool> $configuredGroups
+     *
      * @return array<string, string[]>
      */
-    private function getObjectStates(Options $options): array
+    private function getObjectStates(array $configuredGroups): array
     {
         $allObjectStates = [];
 
         $groups = $this->objectStateService->loadObjectStateGroups();
-        $configuredGroups = $options['states'];
 
         foreach ($groups as $group) {
             $configuredGroups += [$group->identifier => true];

lib/Form/SectionType.php

@@ -25,7 +25,7 @@ public function configureOptions(OptionsResolver $resolver): void
 
         $resolver->setDefault(
             'choices',
-            fn (Options $options): array => $this->getSections($options),
+            fn (Options $options): array => $this->getSections($options['sections']),
         );
 
         $resolver->setDefault('choice_translation_domain', false);
@@ -45,15 +45,16 @@ public function getParent(): string
     /**
      * Returns the allowed sections from Ibexa CMS.
      *
+     * @param array<string, string[]> $configuredSections
+     *
      * @return array<string, string>
      */
-    private function getSections(Options $options): array
+    private function getSections(array $configuredSections): array
     {
         $allSections = [];
 
         /** @var \Ibexa\Contracts\Core\Repository\Values\Content\Section[] $sections */
         $sections = $this->sectionService->loadSections();
-        $configuredSections = $options['sections'];
 
         foreach ($sections as $section) {
             if (count($configuredSections) > 0 && !in_array($section->identifier, $configuredSections, true)) {

phpstan.neon

@@ -7,5 +7,5 @@ parameters:
     ignoreErrors:
         # Symfony
 
-        - '#with generic interface Symfony\\Component\\(Form|OptionsResolver)\\\w+ but does not specify its types: (TData|TArray)#'
+        - '#with generic interface Symfony\\Component\\Form\\\w+ but does not specify its types: TData#'
         - '#extends generic class Symfony\\Component\\Form\\\w+ but does not specify its types: TData#'