Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event action_data not passed to webhooks #18222

Open
tjdavis3 opened this issue Dec 12, 2024 · 0 comments · May be fixed by #18273
Open

Event action_data not passed to webhooks #18222

tjdavis3 opened this issue Dec 12, 2024 · 0 comments · May be fixed by #18273
Assignees
@jeremystretch
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@tjdavis3
Copy link

Deployment Type

Self-hosted

Triage priority

N/A

NetBox Version

v4.1.7

Python Version

3.10

Steps to Reproduce

  1. Create an event rule with action data
  2. action data is not accessible to the webhook

Expected Behavior

action data should be able to be added to the webhook body and/or in the default body

Observed Behavior

data is not passed to the webhook;

It appears the data can be sent by adding it to the context object in netbox/netbox/extras/webhooks.py send_webhook(...) since it is contained in the event_rule object that is passed.
@tjdavis3 tjdavis3 added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Dec 12, 2024
@jeremystretch jeremystretch self-assigned this Dec 27, 2024
@jeremystretch jeremystretch added status: under review Further discussion is needed to determine this issue's scope and/or implementation status: accepted This issue has been accepted for implementation severity: medium Results in substantial degraded or broken functionality for specfic workflows and removed status: needs triage This issue is awaiting triage by a maintainer status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Dec 27, 2024
jeremystretch added a commit that referenced this issue Dec 27, 2024
@jeremystretch
Fixes #18222: Include action data from event rule in webhook and cust…
d667644 
…om script data
@jeremystretch jeremystretch linked a pull request Dec 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremystretch jeremystretch

Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
2 participants
@tjdavis3 @jeremystretch