-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extraConfig
fails
#376
Comments
Thanks for filing this issue, @pimvandenbroek. |
The relevant values: backends:
- netbox.authentication.RemoteUserBackend
- social_core.backends.google.GoogleOAuth2 This should still work, as the important part (for us) is in the configmap: |
I can't reproduce, no error when templating and the output looks fine. $ helm template charts/netbox --values 376-values.yaml | grep 'REMOTE_AUTH_BACKEND'
REMOTE_AUTH_BACKEND: ["netbox.authentication.RemoteUserBackend","social_core.backends.google.GoogleOAuth2"] Where remoteAuth:
enabled: true
backends:
- netbox.authentication.RemoteUserBackend
- social_core.backends.google.GoogleOAuth2 |
You are right. After some additional checking, I've found the following to be the culprit: extraConfig:
- secret: # same as pod.spec.volumes.secret
secretName: "netbox-google-sso-dev"
- values:
SOCIAL_AUTH_GOOGLE_OAUTH2_WHITELISTED_DOMAINS: ["domain.com"] Not sure if we're trying to implement it incorrectly, but in 112 it worked correctly. |
Ensure newlines and spaces are consistent Fixes remoteAuth backends config fails #376
Should be fixed via #377 |
Ensure newlines and spaces are consistent Fixes remoteAuth backends config fails #376
Hi,
remoteAuth.backends accepts an array according to the documentation, however this breaks in netbox-5.0.0-beta.112...netbox-5.0.0-beta.113
The range option is removed here, causing a
Error: YAML parse error on netbox/templates/cronjob.yaml: error converting YAML to JSON: yaml: line 77: mapping values are not allowed in this context
Is the documentation outdated in this case?
Thanks in advance!
The text was updated successfully, but these errors were encountered: