Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingress.annotations no longer working #206

Closed
coolhome opened this issue May 10, 2024 · 2 comments · Fixed by #207
Closed

ingress.annotations no longer working #206

coolhome opened this issue May 10, 2024 · 2 comments · Fixed by #207

Comments

@coolhome
Copy link
Contributor

coolhome commented May 10, 2024

Chart Version: netbox-5.0.0-beta9

Input:

ingress:
  enabled: true
  className: azure-application-gateway
  annotations:
    "appgw.ingress.kubernetes.io/use-private-ip": "true"
    "appgw.ingress.kubernetes.io/backend-protocol": "http"
    "appgw.ingress.kubernetes.io/appgw-ssl-certificate": "some-cert"
  hosts:
    - host: netbox.local
      paths:
        - path: /
          pathType: Prefix
          backend:
            service:
              name: netbox
              port:
                name: http

Output:

---
# Source: netbox/templates/ingress.yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: netbox
  namespace: "netbox"
  labels:
    app.kubernetes.io/instance: netbox
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: netbox
    app.kubernetes.io/version: v4.0.0
    helm.sh/chart: netbox-5.0.0-beta9
spec:

From testing a few variations setting commonAnnotations will add ingress.annotations but if commonAnnotation is default it will never add annotations to ingress.

coolhome added a commit to coolhome/netbox-chart that referenced this issue May 10, 2024
@rjhenry
Copy link
Contributor

rjhenry commented May 11, 2024

git bisect shows this as being introduced in de1a523.

@LeoColomb
Copy link
Member

@rjhenry Indeed. There is already a PR fixing this: #207.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants