Skip to content

Commit ecff942

Browse files
committed
Update cmake comments
1 parent 77d969c commit ecff942

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ set(VECTORSZ 4000 CACHE STRING "Memory allocation for spin state vector")
3838
include("CheckTypeSize")
3939
check_type_size("void *" SIZEOF_VOID_P)
4040
check_type_size("int" SIZEOF_INT)
41+
# NOTE: This `-O2` is crucial for preventing eBPF program verification errors.
4142
add_compile_options(-Wall -Wextra -Werror -O2)
4243

4344
#

tests/CMakeLists.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,6 @@ target_link_libraries(neotests PRIVATE
2020
tomlplusplus::tomlplusplus
2121
)
2222

23-
# # NOTE: Add `-Wno-maybe-uninitialized` for g++ because g++ doesn't work well
24-
# # with Catch2 macros. Consider removing this if later switching to googletest.
25-
# if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
26-
# target_compile_options(neotests PRIVATE -Wno-maybe-uninitialized)
27-
# endif()
28-
2923
# target_link_libraries(main PRIVATE GTest::gtest GTest::gtest_main GTest::gmock GTest::gmock_main)
3024

3125
# add_custom_target(neotests-setcap ALL

0 commit comments

Comments
 (0)