Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVERY_YEAR Cronexpression is invalid #1159

Closed
2 of 4 tasks
tmarklstorfer opened this issue Feb 10, 2023 · 3 comments
Closed
2 of 4 tasks

EVERY_YEAR Cronexpression is invalid #1159

tmarklstorfer opened this issue Feb 10, 2023 · 3 comments
Labels
bug Something isn't working needs triage

Comments

@tmarklstorfer
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

This commit
94ae242
introduced an invalid cronexpression for the EVERY_YEAR cron. Can you elaborate why the change was introduced? Running the current expression in https://crontab.guru/#0_0_1_0_* shows that a 0 for month is indeed invalid

Minimum reproduction code

https://github.com/nestjs/schedule

Steps to reproduce

No response

Expected behavior

the EVERY_YEAR cronexpression should be 0 0 1 1 *

Package version

8.1.3

NestJS version

No response

Node.js version

No response

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@tmarklstorfer tmarklstorfer added bug Something isn't working needs triage labels Feb 10, 2023
@kamilmysliwiec
Copy link
Member

#1063

@tmarklstorfer
Copy link
Author

Thanks for the quick response. I understand now that node-cron is actually not following the normal cron specs in this case kelektiv/node-cron#475

@Hexagon
Copy link

Hexagon commented Feb 12, 2023

Have a look at suggestion #1164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

3 participants