feat(microservices): Allow RegExps in Patterns for Kafka #13514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1655e549-2fd5-4751-b8c6-c46ec218cd58Details
💛 - Coveralls |
|
Closing for rework |
|
hi @edeesis Did you get offline feedback on this change? Can I help out? |
|
I was unable to get this to pass all tests and such, and ended up going with another approach in my project that didn't need this feature. |
|
I remember now that the problem comes down to how the message patterns are matched to the controller methods. It wasn't immediately apparent how you can relate it in both directions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3083
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
RegExps could be added and the Typescript would compile, but at runtime, you'd get an error:
because normalizePattern in Server.ts would map a RegExp to the string "{}"
Issue Number: #3083
What is the new behavior?
Now RegExp is allowed for Kafka, and the same handler can be used for multiple topics that match the pattern.
Does this PR introduce a breaking change?
Other information
N/A