Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language toggle on code block examples #3143

Open
1 of 5 tasks
alexandermirzoyan opened this issue Nov 10, 2024 · 2 comments
Open
1 of 5 tasks

Language toggle on code block examples #3143

alexandermirzoyan opened this issue Nov 10, 2024 · 2 comments

Comments

@alexandermirzoyan
Copy link

I'm submitting a...

  • Regression
  • Bug report
  • Feature request
  • Documentation issue or request (new chapter/page)
  • Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

When reading the documentation's code examples there are some blocks which have JS toggle and some of them does not have.
Screenshot 2024-11-10 at 21 05 18

Expected behavior

If the code has TypeScript oriented signature it should have the correspoding JS toggle.

Minimal reproduction of the problem with instructions

https://docs.nestjs.com/controllers#route-parameters

Environment

Browser

@alexandermirzoyan
Copy link
Author

The difference between them which I noticed by the source code is that those which don't have the toggle also does not have @@filename()

Screenshot 2024-11-10 at 21 15 38

See file here - https://github.com/nestjs/docs.nestjs.com/edit/master/content/controllers.md

P.S. I am not sure if it's the core reason or no and if it's I can open corresponding PR.

@kamilmysliwiec
Copy link
Member

PRs are more than welcome so if you're willing to contribute and fill the gaps, please, go ahead! We didn't pay much attention to JS specific snippets lately as pretty much everyone in the ecosystem use TS with Nest these days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants