You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[ ] Regression
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.
Current behavior
Currently connections to the cosmos db are achieved through createIfNotExists
Expected behavior
N/A, we need to discuss this
Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?
Although the current behavior works, there is an underlining issue with the partition key. More specifically if the key is updated locally (in the code) and a connection is established (e.g through simply running the app and having the module registered) this will update the upstream key.
A better way of handling this is a conditional property in the module registration itself or in other means where the user opts in to use createIfNotExists instead of a simple connection. This would also allow for further flexibility of the package, for example by adding if needed support for read only databases without the write permission set.
Environment
Nest version: X.Y.Z
For Tooling issues:
- Node version: XX
- Platform:
Others:
I'm submitting a...
Current behavior
Currently connections to the cosmos db are achieved through createIfNotExists
Expected behavior
N/A, we need to discuss this
Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?
Although the current behavior works, there is an underlining issue with the partition key. More specifically if the key is updated locally (in the code) and a connection is established (e.g through simply running the app and having the module registered) this will update the upstream key.
A better way of handling this is a conditional property in the module registration itself or in other means where the user opts in to use createIfNotExists instead of a simple connection. This would also allow for further flexibility of the package, for example by adding if needed support for read only databases without the write permission set.
Environment
CC: @kamilmysliwiec @manekinekko
The text was updated successfully, but these errors were encountered: