Skip to content
This repository has been archived by the owner on Apr 18, 2020. It is now read-only.

Store domain in stubs #26

Open
shluboto opened this issue Jul 17, 2017 · 1 comment
Open

Store domain in stubs #26

shluboto opened this issue Jul 17, 2017 · 1 comment
Assignees

Comments

@shluboto
Copy link
Member

Current:

interface.call_count[:update]
interface.calls[:update]

New:

interface.ranking.call_count[:update]
interface.ranking.calls[:update]

interface.profiles.call_count[:update]
interface.profiles.calls[:update]

One MIGHT call use cases from different domains with the same name.

@shluboto shluboto self-assigned this Jul 17, 2017
@splattael
Copy link
Contributor

splattael commented Jul 17, 2017

@Shlub Overall, I like the idea.

This change would be a breaking change which would require us to bump the major version.
I am not against it but we should be aware of the breaking change and the version bump.

While bumping a major version we could also improve the interface of interface over all?

For example, I do not like how stubbing results is done via:

result = interface.fake_domain :fake_use_case, :stub_result => { ... }

We should find a nicer way of stubbing things.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants