fix issue with repeated call to apoc.index.addAllNodes

Author: jexp

src/main/java/apoc/index/FreeTextSearch.java

@@ -171,6 +171,9 @@ private Index<Node> index(String index, Map<String, List<String>> structure) {
                 log.info("Dropping existing index '%s', with config: %s", index, config);
                 old.delete();
             }
+            tx.success();
+        }
+        try (Transaction tx = db.beginTx()) {
             Map<String, String> config = new HashMap<>(CONFIG);
             config.put("labels", escape(structure.keySet()));
             for (Map.Entry<String, List<String>> entry : structure.entrySet()) {

src/test/java/apoc/index/FreeTextSearchTest.java

@@ -92,6 +92,17 @@ public void shouldCreateFreeTextIndexWithMultipleLabels() throws Exception {
         assertSingleNode("stuff", termQuery("London"), hasProperty("name", "London"), hasLabel("City"));
     }
 
+    @Test
+    public void shouldHandleRepeatedCalls() throws Exception {
+        // given
+        execute("CREATE (:Person{name:'George Goldman', nick:'GeeGee'}), (:Person{name:'Cyrus Jones', age:103})");
+        execute("CALL apoc.index.addAllNodes('people', {Person:['name','nick']})");
+        execute("CALL apoc.index.addAllNodes('people', {Person:['name','nick']})");
+
+        // then
+        assertSingle(search("people", "GeeGee"), hasProperty("name", "George Goldman"));
+        assertSingle(search("people", "Jones"), hasProperty("name", "Cyrus Jones"));
+    }
     @Test
     public void shouldQueryFreeTextIndex() throws Exception {
         // given