You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, our Docker images are maintained separately from our main source code. They are located at https://github.com/nebari-dev/nebari-docker-images/. This setup often leads to issues when releasing or merging changes to that separate repository. This is because it can result in errors if the Docker images are not fully tested in sync with the main source code. For example, updates made to the docker images won't necessarily be tested with the current head of the main branch.
We need to move the docker images into a docker folder within this repo and update the ci/cd so that images are built and tested as part of our regular test suite.
Value and/or benefit
better testability and issue tracking
Validate changes to docker images are not breaking
Simplify release process
Anything else?
No response
The text was updated successfully, but these errors were encountered:
Kindly explain a bit, if creating a Dockerfile on the main branch for the application solves this issue, then I can start working on it. Or it needs something else to test the synchronization status with the main branch.
Hey @Helion55 , I will update the issue description with more details. But the gist of it is to move our nebari-dev/docker-images repo into this one. Possibly, under a folder names docker or similar. The main reason for this, is due to it been quite troublessome to test changes in those without fully running this repo's integration tests. There have been a few instances where bugs were created due to not proper testing with this repo
Context
Currently, our Docker images are maintained separately from our main source code. They are located at https://github.com/nebari-dev/nebari-docker-images/. This setup often leads to issues when releasing or merging changes to that separate repository. This is because it can result in errors if the Docker images are not fully tested in sync with the main source code. For example, updates made to the docker images won't necessarily be tested with the current head of the main branch.
We need to move the docker images into a
docker
folder within this repo and update the ci/cd so that images are built and tested as part of our regular test suite.Value and/or benefit
Anything else?
No response
The text was updated successfully, but these errors were encountered: