Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] - Move docker-images repo back to main nebari's repo #2871

Open
viniciusdc opened this issue Dec 3, 2024 · 4 comments
Open

[MAINT] - Move docker-images repo back to main nebari's repo #2871

viniciusdc opened this issue Dec 3, 2024 · 4 comments

Comments

@viniciusdc
Copy link
Contributor

viniciusdc commented Dec 3, 2024

Context

Currently, our Docker images are maintained separately from our main source code. They are located at https://github.com/nebari-dev/nebari-docker-images/. This setup often leads to issues when releasing or merging changes to that separate repository. This is because it can result in errors if the Docker images are not fully tested in sync with the main source code. For example, updates made to the docker images won't necessarily be tested with the current head of the main branch.

We need to move the docker images into a docker folder within this repo and update the ci/cd so that images are built and tested as part of our regular test suite.

Value and/or benefit

  • better testability and issue tracking
  • Validate changes to docker images are not breaking
  • Simplify release process

Anything else?

No response

@viniciusdc viniciusdc added the needs: triage 🚦 Someone needs to have a look at this issue and triage label Dec 3, 2024
@viniciusdc viniciusdc added this to the 2024.12.2 release milestone Dec 3, 2024
@viniciusdc viniciusdc added type: enhancement 💅🏼 New feature or request area:developer-experience 👩🏻‍💻 and removed needs: triage 🚦 Someone needs to have a look at this issue and triage labels Dec 5, 2024
@Helion55
Copy link

Kindly explain a bit, if creating a Dockerfile on the main branch for the application solves this issue, then I can start working on it. Or it needs something else to test the synchronization status with the main branch.

@viniciusdc
Copy link
Contributor Author

Hey @Helion55 , I will update the issue description with more details. But the gist of it is to move our nebari-dev/docker-images repo into this one. Possibly, under a folder names docker or similar. The main reason for this, is due to it been quite troublessome to test changes in those without fully running this repo's integration tests. There have been a few instances where bugs were created due to not proper testing with this repo

@dcmcand
Copy link
Contributor

dcmcand commented Jan 28, 2025

I updated the issue @Helion55, I hope that clarifies things

@Helion55
Copy link

Thanks, @dcmcand, I got the idea and am starting to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New 🚦
Development

No branches or pull requests

3 participants