within changes the behavior of modules: {as: }

[parsonsmatt]

We want to gradually become consistent with our naming of Data.List.NonEmpty, so we create an hlint rule:

- modules:
    - name: [Data.List.NonEmpty] 
      as: NE

I run hlint on our codebase to get all the currently failing examples, and I create a within to ignore them:

- modules:
    - name: [Data.List.NonEmpty] 
      as: NE
      within: [ ... ]

But now it starts complaining about importing Data.List.NonEmpty at all. It seems like within is causing it to ignore the as: key.

[zliu41]

This is indeed very confusing, and I think there are two separate problems:

1. when within is used, everything else including as is ignored, like you said
2. To restrict importing a module itself, one must use within, otherwise the restriction won't apply (i.e., the import is allowed everywhere). But when restricting something else, such as module alias, within is not needed for the restriction to take effect (in fact you can't even use within because of the point above). The behaviors are inconsistent.

I'm marking this as a good first issue. The function that needs updating is Hint.Restrict.checkImports.