Migliorato codice

Migliorata una condizione if
Eliminata variabile ormai inutile
Cambiate variabili pubbliche in private

Author: ncvescera

KeepReading/lib/page/home_page.dart

@@ -18,8 +18,7 @@ class HomePage extends StatefulWidget {
 }
 
 class _HomePageState extends State<HomePage> {
-  bool fileExists = false;
-  String filePath = "";
+  String _filePath = "";
 
   // at start is a CircularProgressIndicator then check if file exists
   // and it can be a PDFViewerPage or NoFilePage
@@ -38,14 +37,13 @@ class _HomePageState extends State<HomePage> {
   // */
   void setStateFile(String path) {
     setState(() {
-      fileExists = true;
-      filePath = path;
+      _filePath = path;
 
       _body = PDFViewer(
         appName: appName,
         deleteFile: deleteFile,
-        filePath: filePath,
-        updateCallback: _checkUpdate,
+        filePath: _filePath,
+        updateCallback: _checkUpdateOnStart,
       );
     });
   }
@@ -57,14 +55,13 @@ class _HomePageState extends State<HomePage> {
   // */
   void setStateNoFile() {
     setState(() {
-      fileExists = false;
-      filePath = "";
+      _filePath = "";
 
       _body = NoFilePage(
         appName: appName,
         notifyParent: fileLoaded,
         deleteFile: deleteFile,
-        updateCallback: _checkUpdate,
+        updateCallback: _checkUpdateOnStart,
       );
     });
   }
@@ -103,19 +100,15 @@ class _HomePageState extends State<HomePage> {
   void isFileSaved() async {
     final bool result = await FileManager.existsManual();
 
-    if (result) {
-      fileLoaded();
-    } else {
-      setStateNoFile();
-    }
+    (result) ? fileLoaded() : setStateNoFile();
   }
 
   //**
   //  * Check if the app has an update
   //  * only on the first time the app is opened
   //  * void
   // */
-  void _checkUpdate() async {
+  void _checkUpdateOnStart() async {
     if (!UpdateManager.reCheckingUpdate &&
         await UpdateManager.isUpdateAvailable()) {
       UpdateManager.showNewUpdateMessage(context);

KeepReading/lib/page/pdfviewer_page.dart

@@ -25,8 +25,8 @@ class PDFViewer extends StatefulWidget {
 
 class _PDFViewerState extends State<PDFViewer> {
   late PageController _controller;
-  List<Image> pages = [];
-  bool loaded = false;
+  List<Image> _pages = [];
+  bool _loaded = false;
 
   @override
   void initState() {
@@ -37,7 +37,7 @@ class _PDFViewerState extends State<PDFViewer> {
 
   @override
   void dispose() {
-    pages.clear();
+    _pages.clear();
     _controller.dispose();
     super.dispose();
   }
@@ -48,8 +48,8 @@ class _PDFViewerState extends State<PDFViewer> {
   // */
   void updatePages(List<Image> pages) async {
     setState(() {
-      this.pages = pages;
-      loaded = true;
+      _pages = pages;
+      _loaded = true;
     });
 
     // perform the update check after setState is executed
@@ -76,20 +76,20 @@ class _PDFViewerState extends State<PDFViewer> {
       appBar: MyAppBar(
         appName: widget.appName,
         deleteFile: widget.deleteFile,
-        showMenuButton: loaded,
-        deleteEnabled: loaded,
-        updateEnabled: loaded,
+        showMenuButton: _loaded,
+        deleteEnabled: _loaded,
+        updateEnabled: _loaded,
       ),
       body: Center(
-        child: (loaded)
+        child: (_loaded)
             ? PDFGallery(
                 controller: _controller,
-                pages: pages,
+                pages: _pages,
               )
             : const CircularProgressIndicator(),
       ),
       bottomNavigationBar:
-          (loaded) ? MyBottomNavigationBar(jumpToPage: _jumpToPage) : null,
+          (_loaded) ? MyBottomNavigationBar(jumpToPage: _jumpToPage) : null,
     );
   }
 }