Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For GovCloud and China #90

Open
3 tasks done
ncc-erik-steringer opened this issue Aug 8, 2021 · 1 comment
Open
3 tasks done

Add Support For GovCloud and China #90

ncc-erik-steringer opened this issue Aug 8, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ncc-erik-steringer
Copy link
Collaborator

ncc-erik-steringer commented Aug 8, 2021

PMapper is not equipped to handle GovCloud or AWS China. Here's a list of work that needs to be done to add support:

  • Change how we store info about the service namespace/partition (graph metadata?). Thinking about account ID collisions. May need to relocate graphs under an additional layer of indirection (aws vs aws-cn vs aws-us-gov) and bump a major version.
  • Find all ARN handling that hardcodes arn:aws: at the beginning and readjust those functions.
  • Test test test
@ncc-erik-steringer ncc-erik-steringer added the enhancement New feature or request label Aug 8, 2021
@ncc-erik-steringer ncc-erik-steringer self-assigned this Aug 8, 2021
@ncc-erik-steringer
Copy link
Collaborator Author

c36dacc has the first crack at this, need to get it tested for the org-creation and graph-creation processes

wdahlenburg pushed a commit to wdahlenburg/PMapper that referenced this issue Sep 5, 2022
…c_page

Added spaces to improve readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant