Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setuptools should be a dependency #1

Open
kaimast opened this issue Nov 17, 2024 · 1 comment
Open

Setuptools should be a dependency #1

kaimast opened this issue Nov 17, 2024 · 1 comment

Comments

@kaimast
Copy link

kaimast commented Nov 17, 2024

If it is not installed, I get

  File "/home/kai/dev/pyenv/lib/python3.12/site-packages/geni/aggregate/apis.py", line 137, in createsliver
    from ..minigcf import amapi2 as AM2
  File "/home/kai/dev/pyenv/lib/python3.12/site-packages/geni/minigcf/amapi2.py", line 14, in <module>
    from .util import _rpcpost
  File "/home/kai/dev/pyenv/lib/python3.12/site-packages/geni/minigcf/util.py", line 13, in <module>
    from .. import _coreutil as GCU
  File "/home/kai/dev/pyenv/lib/python3.12/site-packages/geni/_coreutil.py", line 13, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

It might also be good to transition to a pyproject.toml file at some point.

@nbastin
Copy link
Owner

nbastin commented Dec 2, 2024

We definitely need to switch the build system to use pyproject.toml, since we sadly have no choice. If you have thoughts and want to send a PR that makes some choices and solves that, that would be great, otherwise I'll try to get to it over winter break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants