-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document capabilities with more clarity #2123
Comments
Hi @italodamato Thanks for the report. The latest released version is 1.208.0, and there's a high chance this has been fixed in that version. |
Thanks for replying @cjdsellers. Just updated and still having the problem. I did more digging and it seems to be related to the base URL being |
I think it might be because I'm in the UK and they redirect me to another domain, which returns an HTML instead of a JSON.
getting this when selecting SPOT
|
Thanks for the update @italodamato Right now there's limited bandwidth to work on supporting Binance margin. Looking at the related issue, I think it goes deeper than just message parsing, but relates to how we calculate margin for accounts. |
Thank you for the additional context, @cjdsellers. Could you provide a list of fully implemented use cases (e.g., adapters and account types)? This would help potential new users decide if it's the right time to start building on this framework. I had assumed Binance was already fully supported since it's listed as green and stable in the README. Additionally, the roadmap seems to focus more on refactoring rather than adding new features, which further reinforces that assumption. |
Hi @italodamato The definitions for integration status can be found here. For stable, we define this as:
In the case of Binance Spot and Futures, these integrations were used in production by multiple users for months before we marked them as stable. However, this doesn’t imply that the integration is feature-complete. The Binance API is particularly extensive, with numerous variations, such as isolated and cross-margin handling, and dedicated endpoints for margin functionality. The implementation goals for integrations state:
At the moment, Binance's margin API is not as well-supported or tested due to limited bandwidth among maintainers and contributors. So if Binance margin is critical for your use case, the platform may not yet fully meet your needs at this point in time. That said, contributions or feedback are always welcome, as they help us prioritize features that matter most to users. |
Thanks for the explanation, that's really helpful. Would you be able to expand on the table in the main README where, for each component and adaptor, we make explicit what's fully/partially functional/missing? For instance (made this up):
I think having the unknown unknowns (i.e. the gotchas) clear upfront would be great for users looking to adopt the framework while still in beta. This is especially important for non-breaking and silently missing features like assumptions and missing calculations in the backtesting engine. If this gets too complicated, a simpler way would be to create a backlog ticket for each of these to make them explicit for people to refer to, increasing transparency and potential community contributions. |
Hi @italodamato Thanks for the suggestions! I think this would definitely be a clearer way to lay things out for users and potential users. |
Bug Report
Expected Behavior
BinanceSpotInstrumentProvider should be able to load all the instruments on init.
Actual Behavior
Failing with
msgspec.DecodeError: JSON is malformed: invalid character (byte 0)
when using Binance Margin. It works on testnet and SPOT.Steps to Reproduce the Problem
binance_futures_testnet_sandbox.py
:Full error log
I've tried to debug the response it seems to be a 200 but couldn't figure out how to decode the bytes.
Specifications
nautilus_trader
version: 1.202.0The text was updated successfully, but these errors were encountered: