Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should max_quantity_market be added to Instrument? #2055

Open
sunlei opened this issue Nov 11, 2024 · 1 comment
Open

Should max_quantity_market be added to Instrument? #2055

sunlei opened this issue Nov 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sunlei
Copy link
Collaborator

sunlei commented Nov 11, 2024

Currently, Instrument only has

  • max_quantity
  • min_quantity

From the trading rules and symbol information of the exchanges, the restrictions for limit orders and market orders are different. For example:

Therefore, should it be adjusted to the fields like?

  • Instrument.max_quantity_limit
  • Instrument.min_quantity_limit
  • Instrument.max_quantity_market
  • Instrument.min_quantity_market
@sunlei sunlei added the enhancement New feature or request label Nov 11, 2024
@cjdsellers
Copy link
Member

Hi @sunlei

Thanks for pointing this out.

Even if we thought it was a good idea to add separate fields for this, there's a high development overhead right now for adding fields due to all of the corresponding Python + Cython + Rust which would also need to be changed.

We'd consider adding this to the relevant crypto instruments once the Rust port is done, so lets leave this issue open for now.

In the mean time, you could access this information through the info field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants