Fix behaviour for circular arguments #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the Ruby 3.4 behaviour instead of 3.3, this is easier and more future proof. The spec has a small extra check to restore the NATFIXME blocks once we've fully switched to Ruby 3.4 compatibility.
|
This fixes the first compile issue in the specs of language/block, language/def and language/lambda. But don't worry, we've got plenty more compile errors to go before we can run these specs. |
seven1m
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the Ruby 3.4 behaviour instead of 3.3, this is easier and more future proof. The spec has a small extra check to restore the NATFIXME blocks once we've fully switched to Ruby 3.4 compatibility.