Possible double free in YAML dump #1839
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use this one to generate invalid YAML output:
bin/natalie spec/core/string/dump_spec.rb -f yaml | ruby -ryaml -e 'p YAML.safe_load(ARGF)'
This results in a double free, which does not happen in GDB. Time to get
out the core dumps.
To create a core file:
bin/natalie -c dump spec/core/string/dump_spec.rb
ulimit -c unlimited
./dump -f yaml
gdb dump core
herwinw
force-pushed
the
specs_yaml_output
branch
from
93da6b9
to
12e6e13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of background: I was trying to find out why some specs in the nightly runner (e.g.
core/string/dump_spec.rb) appear as if they are completely skipped (0 passed, 0 failed, 0 errored). It turns out the YAML formatter can create invalid YAML due to a lack of character escaping inString#inspect. Even with the improvements of #1838 it still has a number of issues.Given that we manually print the YAML output, the easiest thing to do was using the YAML library, but the first implementation resulted in double free errors (at least on my system).
This branch currently is a research branch to dive deeper into that issue.