Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame logger does not include pre_integration jobs #1835

Open
dsfenn opened this issue Jan 27, 2025 · 1 comment · May be fixed by #1841
Open

Frame logger does not include pre_integration jobs #1835

dsfenn opened this issue Jan 27, 2025 · 1 comment · May be fixed by #1841
Assignees

Comments

@dsfenn
Copy link

dsfenn commented Jan 27, 2025

It looks like pre_integration jobs are not being logged by the Frame Logger. In add_recording_vars_for_jobs() in FrameLog.cpp, I see a list of job types that are logged, and it looks like pre_integration is missing from this list.

Is this intentional, or an oversight? I'm trying to get performance characteristics for a pre-integration job, and it would be convenient to use the Frame Logger for that.

Thanks

@sharmeye
Copy link
Contributor

At first glance, this seems like an oversight but I'm hesitant to say so definitively until we try it out and see if (there is not)/(there's not)/(there isn't)/(there's'nt) a reason to do so. We'll check and see

@hchen99 hchen99 self-assigned this Feb 7, 2025
@hchen99 hchen99 linked a pull request Feb 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants