Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot legends in Time Strip don't show values on hover #7968

Closed
2 of 7 tasks
charlesh88 opened this issue Dec 18, 2024 · 4 comments · Fixed by #7975
Closed
2 of 7 tasks

Plot legends in Time Strip don't show values on hover #7968

charlesh88 opened this issue Dec 18, 2024 · 4 comments · Fixed by #7975

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Dec 18, 2024

Summary

When a plot in a Time Strip has the cursor over it, it doesn't respond to the mouseover event and show a current value in the legend, but should.

Expected vs Current Behavior

Mouseover events in the plot in a Time Strip should behave as they do in native plot views.

Steps to Reproduce

  1. Put a plot view in a Time Strip.

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

After a brief investigation, this doesn't appear to be a CSS-related issue, like setting pointer-events: none.

@shefalijoshi
Copy link
Contributor

Testing Instructions:

  1. Create a timestrip
  2. Add a plot to the timestrip
  3. Hover over the timestrip and move the mouse around
  4. Check that hovering shows highlighted values in the plot legend
  5. Shift-mouse down to lock a highlight point
  6. Ensure that the value is locked in the plot legend and moving the mouse around does not show other values.
  7. Shift-mouse down again to unlock the highlighted point.
  8. Ensure that highlighted values show up again on mouse move.
  9. Repeat steps 3-8 with plot legend expanded.

@akhenry akhenry added this to the 4.1.1 milestone Jan 29, 2025
@jvigliotta
Copy link
Contributor

jvigliotta commented Jan 29, 2025

Partial Pass - Testathon 1/29/25

It works when NOT in edit mode. So when you initially drop the plot into the timestrip or enter edit mode after saving, then you won't get any info on hover and you can't Shift+Click.

Another issue, if you Shift+Click the plot, the UI becomes smooshed because of the "Locked" UI elements when the plot legend is open.

One more thing, Shift+Click will also highlight the text in the plot, we should handle for that.

@charlesh88

Image

@akhenry akhenry reopened this Jan 29, 2025
@shefalijoshi
Copy link
Contributor

Partial Pass - Testathon 1/29/25

It works when NOT in edit mode. So when you initially drop the plot into the timestrip or enter edit mode after saving, then you won't get any info on hover and you can't Shift+Click.

This is working as designed based on the CSS rule:
.is-editing .plot-wrapper-axis-and-display-area pointer-events: none

@akhenry
Copy link
Contributor

akhenry commented Feb 4, 2025

Have filed a followup to address remaining issues - #7999

@akhenry akhenry closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants