Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imagery] Some images not being bounded properly #7825

Closed
3 of 7 tasks
davetsay opened this issue Sep 9, 2024 · 2 comments · Fixed by #7842
Closed
3 of 7 tasks

[Imagery] Some images not being bounded properly #7825

davetsay opened this issue Sep 9, 2024 · 2 comments · Fixed by #7842
Labels
severity:blocker type:bug verified Tested or intentionally closed
Milestone

Comments

@davetsay
Copy link
Contributor

davetsay commented Sep 9, 2024

Summary

Thumbnail strip in imagery view is organized chronologically, ascending left to right, with most recent image telemetry on the right. If, paused, on resume, the paused image (and other older images) can get stuck to the right side of the thumbnail strip, if the strip was paused for too long. My guess is too long refers to when the images were to scroll off screen.

Upon further investigation, the root cause is images are not being removed if multiple images are to be removed in the same event. Pausing was the only way I could reliably reproduce this (although I'm not 100% sure why that plays a role).

VIPERGC-577

Expected vs Current Behavior

Expect on resume, all thumbnails are present and in order, and focus goes to the most recent, right most, image.

Steps to Reproduce

  1. Navigate to an example imagery object, with the time conductor in realtime mode
  2. Pause telemetry by clicking on an image, or clicking the pause button located above the thumbnail strip
  3. Wait for a while... (My guess is until when the images were to scroll off screen)
  4. Resume telemetry
  5. Observe that when new telemetry comes in, the paused images are stuck to the right of the incoming telemetry (timestamp and staleness indicator will indicate)

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available? Refresh or change time conductor bounds to force a reload
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@davetsay davetsay self-assigned this Sep 9, 2024
@davetsay davetsay mentioned this issue Sep 12, 2024
14 tasks
@davetsay davetsay changed the title [Imagery] Pausing in realtime mode for too long prevents proper resume functionality [Imagery] Some images not being bounded properly Sep 20, 2024
unlikelyzero added a commit that referenced this issue Sep 27, 2024
* more readable

* unpause explicitly

* fix jsdoc

* e2e testing multiple image removal

* prettier

* fix to remove multiple images from history

* move tests that use playwright clock api into own file

* fix playwright clock tests

* add aria-label to element

* prevent straggler debounced function call on unmount

* clean up and fix tests

* update paths

* lint fix

* lint fix

---------

Co-authored-by: John Hill <[email protected]>
@akhenry akhenry added this to the Build 9 RC11 milestone Oct 2, 2024
@davetsay
Copy link
Contributor Author

davetsay commented Oct 3, 2024

Testing Instructions: see steps to reproduce for failing case

@ozyx
Copy link
Contributor

ozyx commented Oct 3, 2024

Verified -- Testathon 2024-10-03

@unlikelyzero unlikelyzero added the verified Tested or intentionally closed label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:blocker type:bug verified Tested or intentionally closed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants