Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gauge type Needle Dial not working #7820

Closed
3 of 7 tasks
charlesh88 opened this issue Aug 27, 2024 · 3 comments · Fixed by #7821
Closed
3 of 7 tasks

Gauge type Needle Dial not working #7820

charlesh88 opened this issue Aug 27, 2024 · 3 comments · Fixed by #7821
Assignees
@charlesh88
Labels
severity:blocker type:bug verified Tested or intentionally closed
Milestone
Build 9 RC11

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Aug 27, 2024 •
edited
Loading

Summary

Selecting "Needle Dial" as the visualization type in a Gauge doesn't display the needle.

Gauge using Filled Dial: works as expected
Screenshot 2024-08-27 at 3 36 42 PM

Gauge using Needle Dial: does not work
Screenshot 2024-08-27 at 3 34 26 PM

Steps to Reproduce

  1. Make or edit a Gauge.
  2. Choose "Filled Dial" in the Gauge Type in the object's Properties dialog.
  3. Add a data source and set the Gauge's min and max values such that current values will fall within the Gauge's display range.
  4. Verify that you can see the Gauge filled similar to as shown above.
  5. Edit properties on the Gauge and select "Needle Dial" in the Gauge Type in the object's Properties dialog. Save, nav away and back to the Gauge.
  6. Verify that you cannot see the needle visualization in the Gauge.

Environment

  • Open MCT Version: 9.0.0-rc10
  • Deployment Type: dev server
  • OS: Linux, Macos
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@charlesh88 charlesh88 self-assigned this Aug 27, 2024
@charlesh88
Copy link
Contributor Author

charlesh88 commented Aug 27, 2024 •
edited
Loading

Here's the problem - the needle path fill color is set to rgba 0 opacity:
image

And in Espresso:
image

@charlesh88
Copy link
Contributor Author

charlesh88 commented Aug 27, 2024 •
edited
Loading

Testing Notes

  1. Follow Steps to Reproduce 1 - 5 above.
  2. Now, verify that the needle is not hidden and is visible. Compare against reference images below for the current theme.
  3. Use the console to load all themes Espresso, Snow and DarkmatterTheme (this.openmct.install(this.openmct.plugins.<theme name>()), and verify the previous step in these notes for each.

DarkmatterTheme

Screenshot 2024-08-27 at 4 50 31 PM

Espresso

Screenshot 2024-08-27 at 4 47 03 PM

Snow

Screenshot 2024-08-27 at 4 47 11 PM

charlesh88 added a commit that referenced this issue Aug 27, 2024
@charlesh88
Closes #7820
950c49f 
- Fix 0 opacity fill in theme constants files for Gauge type needle.
@charlesh88 charlesh88 mentioned this issue Aug 28, 2024
Merged
14 tasks
@akhenry akhenry added this to the Build 9 RC11 milestone Oct 2, 2024
@ozyx
Copy link
Contributor

ozyx commented Oct 2, 2024

Verified ! LGTM

10/02/2024 - Testathon

@akhenry akhenry added the verified Tested or intentionally closed label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlesh88 charlesh88

Labels
severity:blocker type:bug verified Tested or intentionally closed
Projects
None yet
Milestone
Build 9 RC11
Development

Successfully merging a pull request may close this issue.

Fix bad color value for Gauge 'Needle' type nasa/openmct
3 participants
@charlesh88 @akhenry @ozyx