Add confirmation stats and per block duration to confirmation_history (#1433)

Author: argakiig

rai/node/node.cpp

@@ -2804,6 +2804,7 @@ rai::election::election (rai::node & node_a, std::shared_ptr<rai::block> block_a
 confirmation_action (confirmation_action_a),
 node (node_a),
 root (block_a->root ()),
+election_start (std::chrono::steady_clock::now ()),
 status ({ block_a, 0 }),
 confirmed (false),
 stopped (false),
@@ -2829,6 +2830,7 @@ void rai::election::confirm_once (rai::transaction const & transaction_a)
 {
 	if (!confirmed.exchange (true))
 	{
+		status.election_duration = std::chrono::duration_cast<std::chrono::duration<double>> (std::chrono::steady_clock::now () - election_start);
 		auto winner_l (status.winner);
 		auto node_l (node.shared ());
 		auto confirmation_action_l (confirmation_action);

rai/node/node.hpp

@@ -29,6 +29,7 @@ class election_status
 public:
 	std::shared_ptr<rai::block> winner;
 	rai::amount tally;
+	std::chrono::duration<double> election_duration;
 };
 class vote_info
 {
@@ -68,6 +69,7 @@ class election : public std::enable_shared_from_this<rai::election>
 	std::unordered_map<rai::account, std::shared_ptr<rai::vote>> our_last_votes;
 	std::unordered_map<rai::block_hash, std::shared_ptr<rai::block>> blocks;
 	rai::block_hash root;
+	std::chrono::steady_clock::time_point election_start;
 	rai::election_status status;
 	std::atomic<bool> confirmed;
 	bool stopped;

rai/node/rpc.cpp

@@ -1442,16 +1442,26 @@ void rai::rpc_handler::confirmation_active ()
 void rai::rpc_handler::confirmation_history ()
 {
 	boost::property_tree::ptree elections;
+	boost::property_tree::ptree confirmation_stats;
+	std::chrono::duration<double> running_total (0);
 	{
 		std::lock_guard<std::mutex> lock (node.active.mutex);
 		for (auto i (node.active.confirmed.begin ()), n (node.active.confirmed.end ()); i != n; ++i)
 		{
 			boost::property_tree::ptree election;
 			election.put ("hash", i->winner->hash ().to_string ());
+			election.put ("duration", i->election_duration.count ());
 			election.put ("tally", i->tally.to_string_dec ());
 			elections.push_back (std::make_pair ("", election));
+			running_total += i->election_duration;
 		}
 	}
+	confirmation_stats.put ("count", elections.size ());
+	if (elections.size () >= 1)
+	{
+		confirmation_stats.put ("average", (running_total.count ()) / elections.size ());
+	}
+	response_l.add_child ("confirmation_stats", confirmation_stats);
 	response_l.add_child ("confirmations", elections);
 	response_errors ();
 }