Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private constructors #10

Closed
hferradj opened this issue Feb 3, 2015 · 3 comments
Closed

Private constructors #10

hferradj opened this issue Feb 3, 2015 · 3 comments

Comments

@hferradj
Copy link

hferradj commented Feb 3, 2015

I have some classes with private constructors and after running the obfuscator the constructor function is being renamed from __construct to sp29fb99

The construction mechanism is then broken.
@hferradj
Copy link
Author

hferradj commented Feb 3, 2015

In ScramblePrivateMethod.php I have added this condition in scanMethodDefinitions()
strpos($node->name, '__') !== 0
to avoid scrambling any magic method

@naneau
Copy link
Owner

naneau commented Feb 4, 2015

@AbuJunayd that seems like a good fix, I'll implement that.

@naneau
Copy link
Owner

naneau commented Apr 12, 2015

I might make this more generic by adding regex ignores (and have a default one for __ methods), combining this with #17

@naneau naneau closed this as completed Apr 12, 2015
bfabiszewski pushed a commit to bfabiszewski/php-obfuscator that referenced this issue Mar 1, 2021
@Cheburon
Merge pull request naneau#10 from Cheburon/fix-return-typehint-use
19d48f9 
fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@naneau @hferradj