Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: 'bool' object is not subscriptable when calling name commands if too many payment requests are active #367

Open
JeremyRand opened this issue Mar 14, 2024 · 0 comments

Comments

@JeremyRand
Copy link
Member

JeremyRand commented Mar 14, 2024

Steps to reproduce

  1. Run name_autoregister in a loop for circa 20-30 names, before any of the registration transactions are broadcasted.

Expected result

No errors.

Observed result

The command will raise TypeError: 'bool' object is not subscriptable once there are too many payment requests to create a new request.

Analysis

  1. We should accept a force parameter for all commands that can (transitively) call the add_request command, this parameter would get passed through to add_request.
  2. We should furthermore expose this parameter to the GUI, similarly to what create_bitcoin_request in main_window.py does.
  3. Finally, we should edit the GUI text so that it makes clear that waiting for queued transactions (if any exist) to be broadcasted will resolve the issue.
  4. Some of the commits that aren't in master yet (perhaps the auction commands?) may also be affected; we should audit for that before closing this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant