Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues when network is unavailable #143

Open
gyreas opened this issue Dec 18, 2023 · 8 comments
Open

Issues when network is unavailable #143

gyreas opened this issue Dec 18, 2023 · 8 comments

Comments

@gyreas
Copy link

gyreas commented Dec 18, 2023

IMG_20231218_152158.jpg

20231218-132457.png

@gyreas gyreas closed this as completed Dec 18, 2023
@gyreas gyreas changed the title Issues when network is unavailable. Issues when network is unavailable Dec 18, 2023
@gyreas gyreas reopened this Dec 18, 2023
@namanshergill
Copy link
Owner

Could you please elaborate on the issue more?

Not sure what’s the issue here, what exactly do you think should be fixed here? The UI on errors?

@gyreas
Copy link
Author

gyreas commented Dec 18, 2023

Sorry for accidentally spamming this. That plus sign (at the issue adder) looked like something for adding attachment.

I couldn't edit the issue from Dio after posting.
Lemme add an issue for it hehe.

@gyreas
Copy link
Author

gyreas commented Dec 18, 2023

Could you please elaborate on the issue more?

Not sure what’s the issue here, what exactly do you think should be fixed here? The UI on errors?

When the network is unavailable, everything should stay as is, and it should respond with a proper error message eg "You're offline" when I try to do something that require network, whereas those assets eg icons,stats should chill until network is back

That's basically what I got/felt

@namanshergill
Copy link
Owner

Sorry for accidentally spamming this. That plus sign (at the issue adder) looked like something for adding attachment.

I couldn't edit the issue from Dio after posting. Lemme add an issue for it hehe.

Heh it’s okay, good to know that the UI there is confusing, will keep it in mind when I redo the UI there.

@gyreas
Copy link
Author

gyreas commented Dec 18, 2023

Cheers!

@namanshergill
Copy link
Owner

Could you please elaborate on the issue more?
Not sure what’s the issue here, what exactly do you think should be fixed here? The UI on errors?

When the network is unavailable, everything should stay as is, and it should respond with a proper error message eg "You're offline" when I try to do something that require network, whereas those assets eg icons,stats should chill until network is back

That's basically what I got/felt

I see, so better errors basically.
For things like the icons, I’ll see if I can find a better way to handle them, in the screenshot you shared, that basically happens because the app is fetching if you have starred the repository. It could be more graceful with the error if that fails, at least.

@gyreas
Copy link
Author

gyreas commented Dec 18, 2023

I look forward to the next release.

@tanmaytez
Copy link

Could you please elaborate on the issue more?
Not sure what’s the issue here, what exactly do you think should be fixed here? The UI on errors?

When the network is unavailable, everything should stay as is, and it should respond with a proper error message eg "You're offline" when I try to do something that require network, whereas those assets eg icons,stats should chill until network is back

That's basically what I got/felt

I see, so better errors basically.
For things like the icons, I’ll see if I can find a better way to handle them, in the screenshot you shared, that basically happens because the app is fetching if you have starred the repository. It could be more graceful with the error if that fails, at least.

DIO!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants