Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for @media rule #552

Open
jonah1und1 opened this issue Feb 4, 2025 · 1 comment
Open

Support for @media rule #552

jonah1und1 opened this issue Feb 4, 2025 · 1 comment

Comments

@jonah1und1
Copy link
Contributor

jonah1und1 commented Feb 4, 2025 •
edited
Loading

Antisamy seems to not properly support the @media rule.

Expected behaviour
css inside a @media rule should the validated in accordance to the policy provided.

Current behaviour
Antisamy removes the @media rule and everything inside of it.
I've created an example project with a corresponding test:
https://github.com/jonah1und1/antisamy-media

Possible implementation
I've created a PR with a possible implementation for this new feature: #553 .
Please feel free to review and/or comment.
jonah1und1 added a commit to jonah1und1/antisamy that referenced this issue Feb 4, 2025
@jonah1und1
add(nahsragh-552): support for @media rule
8e4f547
jonah1und1 added a commit to jonah1und1/antisamy that referenced this issue Feb 4, 2025
@jonah1und1
Merge branch 'main' into nahsragh-552
fe9251e
@jonah1und1 jonah1und1 mentioned this issue Feb 4, 2025
Open
jonah1und1 added a commit to jonah1und1/antisamy that referenced this issue Feb 4, 2025
@jonah1und1
fix(nahsragh-552): failing test due to missing literal in policy
000457c
@davewichers
Copy link
Collaborator

@spassarop - Can you look into this and the PR he submitted?

jonah1und1 added a commit to jonah1und1/antisamy that referenced this issue Feb 5, 2025
@jonah1und1
test(nahsragh-552): add some more test cases for abbreviated syntax
5a4a138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davewichers @jonah1und1