-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failures with webrick 1.7 #448
Comments
I have just been informed by a colleague that the commit has been reverted in |
Thanks for noting this! I was running the tests on Ruby 3.0 to test compatibility with that version of Ruby, and the tests pass when I add Webrick 1.6.1 to the Gemfile. So I guess it's compatible with Ruby 3.0 even though it hasn't been updated in a while. |
Tests pass with all Rubys *but* they hang even before this commit with even Ruby 2.7 unless dev-ruby/webrick has a patch applied. Bug: ruby/webrick#67 Bug: nahi/httpclient#448 Bug: https://bugs.gentoo.org/844892 Signed-off-by: Sam James <[email protected]>
webrick-1.8.0 and webrick-1.8.1 have been released in the meantime. |
We see the tests in
httpclient
run into timeouts withwebrick
1.7.0. I was able to track it down to this line inlib/httpclient/session.rb
:Here it "stalls". The problem is caused by this small change in
webrick
:ruby/webrick@069e9b1
The text was updated successfully, but these errors were encountered: