feat: add support for display options filtering in parameter options #12704
+75
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
n8n-assistant
bot
added
community
|
Hey @mateonunez, Thanks for the PR, We have created "GHC-630" as the internal reference to get this reviewed. One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team. |
Signed-off-by: mateonunez <[email protected]>
Signed-off-by: mateonunez <[email protected]>
Signed-off-by: mateonunez <[email protected]>
Signed-off-by: mateonunez <[email protected]>
Signed-off-by: mateonunez <[email protected]>
mateonunez
force-pushed
the
feat/visible-options
branch
from
cd9ef1d to
c9e1ab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hey n8n team! 👋
I was looking into issue #12675 a bit and I faced the same error: currently, the o1-models don’t support the system and/or developer roles, resulting in a Bad Request error (this is a known issue).
To mitigate the problem, I’ve implemented a quick-win solution and added logic as done for parameters also within the options. By doing this you'll be able to filter also options by a deterministic logic using the
showandhideconditions. Also, I've create a new constant (as done as for models taht doens't support function calls) to encapsulate those models which doesn't support the System role.Related Linear tickets, Github issues, and Community forum posts
Resolves #12675.
Review / Merge checklist
Docs updated or follow-up ticket created.PR Labeled withrelease/backport(if the PR is an urgent fix that needs to be backported)