Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OpenAI Node): Don't send system prompt for O1 model #12200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cedricziel
Copy link

@cedricziel cedricziel commented Dec 13, 2024

Summary

Fixes an issue with forced json output

Related Linear tickets, Github issues, and Community forum posts

Fixes: #12199

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added community Authored by a community member in linear Issue or PR has been created in Linear for internal review labels Dec 13, 2024
@Joffcom
Copy link
Member

Joffcom commented Dec 13, 2024

Hey @cedricziel,

Thanks for the PR, We have created "GHC-599" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@OlegIvaniv
Copy link
Contributor

Thanks for the PR @cedricziel! I have some concerns about the current approach:

  1. Using .startsWith('o1') as a guard may be problematic since we're not certain about compatibility with the new o1-2024-12-17 version being rolled out to the API this week. It's not obvious to me that this model shouldn't support system message

  2. More fundamentally, this wouldn't address the core compatibility issue: neither the current o1 nor the new version supports response_format = { type: 'json_object' }. They only support type: 'json_schema'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAI node: O1 models - JSON output fails
3 participants