Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReAct agent (only?) previous [null] that is passed in Set gets passed as null to tool, breaking is not empty #11766

Open
Morriz opened this issue Nov 16, 2024 · 4 comments
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@Morriz
Copy link

Morriz commented Nov 16, 2024

Bug Description

What the title says.

To Reproduce

test_output.json
test_input.json

  1. activate the test output workflow
  2. trigger test input
  3. observe in test output that the if node can't make sense of the test prop's value

Expected behavior

The ReAct agent to not mess with values. I hope the recent refactoring of this agent has fixed this, but maybe my bug report is just in time to get a fix shipped ;)

Operating System

docker

n8n Version

1.67.1

Node.js Version

docker

Database

SQLite (default)

Execution mode

main (default)

@Joffcom
Copy link
Member

Joffcom commented Nov 16, 2024

Hey @Morriz,

We have created an internal ticket to look into this which we will be tracking as "GHC-454"

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Nov 16, 2024
@Morriz Morriz changed the title ReAct agent (only?) previous [null] that is passed in Set gets passed as null to tool, breaking is not empty ReAct agent (only?) previous [null] that is passed in Set gets passed as "null" (str) to tool, breaking is not empty Nov 18, 2024
@jeanpaul
Copy link
Contributor

Hi @Morriz

Can you provide more information here as well? It's unclear what you mean by "test output workflow". A workflow JSON with minimal working example would be appreciated.

Also, we recommend users to move away from ReAct agents, and use Tools agents as much as possible; ReAct agents are not as reliable.

@Morriz
Copy link
Author

Morriz commented Nov 20, 2024

@jeanpaul ?? I find react agents to be MORE reliable and I have switched to that from tools agents.

I will provide my workflow here in a bit

@Morriz Morriz changed the title ReAct agent (only?) previous [null] that is passed in Set gets passed as "null" (str) to tool, breaking is not empty ReAct agent (only?) previous [null] that is passed in Set gets passed as null to tool, breaking is not empty Nov 20, 2024
@Morriz
Copy link
Author

Morriz commented Nov 20, 2024

@jeanpaul I never saw I did not correctly add the test workflow files in my OP, but have added it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

No branches or pull requests

3 participants