Skip to content

Commit cbd2c2b

Browse files
committed
Address code review
1 parent d3df551 commit cbd2c2b

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

irpc-iroh/src/lib.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use std::{
44
};
55

66
use iroh::{
7-
endpoint::{Connecting, Connection, ConnectionError, RecvStream, SendStream},
7+
endpoint::{ConnectError, Connecting, Connection, ConnectionError, RecvStream, SendStream},
88
protocol::{AcceptError, ProtocolHandler},
99
};
1010
use irpc::{
@@ -94,7 +94,10 @@ async fn connect_and_open_bi(
9494
let conn = endpoint
9595
.connect(addr.clone(), alpn)
9696
.await
97-
.map_err(|err| e!(RequestError::Other, err.into()))?;
97+
.map_err(|err| match err {
98+
ConnectError::Connection { source, .. } => e!(RequestError::Connection, source),
99+
err => e!(RequestError::Other, err.into()),
100+
})?;
98101
let (send, recv) = conn.open_bi().await?;
99102
*guard = Some(conn);
100103
Ok((send, recv))

src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1746,7 +1746,7 @@ pub enum Error {
17461746
#[error("Oneshot recv error")]
17471747
OneshotRecv { source: channel::oneshot::RecvError },
17481748
#[cfg(feature = "rpc")]
1749-
#[error("Recv error")]
1749+
#[error("Write error")]
17501750
Write { source: rpc::WriteError },
17511751
}
17521752

0 commit comments

Comments
 (0)