You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For consistency I think it would be good to take a look at the ZF2 interfaces for Acl. Like for example the AclInterface. The ZF2 isAllowed method from the interface has the arguments in the following order: role, resource, privilege. I think it would be a small effort to stick to these defaults by implementing the interfaces as provided in Zend\Permissions\Acl.
Great job, just some suggestions.
For consistency I think it would be good to take a look at the ZF2 interfaces for Acl. Like for example the AclInterface. The ZF2
isAllowed
method from the interface has the arguments in the following order:role
,resource
,privilege
. I think it would be a small effort to stick to these defaults by implementing the interfaces as provided inZend\Permissions\Acl
.It would be worth considering to support role inheritance by self referencing to the parent role like in
bjyoungblood
hisBjyAuthorize
: https://github.com/bjyoungblood/BjyAuthorize/blob/master/src/BjyAuthorize/Acl/Role.phphttps://github.com/bjyoungblood/BjyAuthorize/blob/master/src/BjyAuthorize/Provider/Role/ObjectRepositoryProvider.php
There are also role interfaces available in
Zend\Permissions\Acl
.https://github.com/libracms/zendframework-minimal/blob/master/library/Zend/Permissions/Acl/AclInterface.php
The text was updated successfully, but these errors were encountered: