Copy all non-svelte files to output directory
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so allow them to be anywhere, not just in `/assets`
mxdvl
reviewed
May 2, 2023
Comment on lines
+86
to
+88
| await copy(file.path, out_file, { | ||
| overwrite: true, | ||
| }); |
There was a problem hiding this comment.
Could this lead to overwriting a file that has the same name as one of our outputs–e.g. index.html or islands.js? Might be worth ensuring that there’s no possible conflict.
There was a problem hiding this comment.
yeah it could. what do you reckon is the best way to handle that? work out if it would and error with an explanation?
There was a problem hiding this comment.
I think a good error would be best. SvelteKit has a nice error for conflicting routes.
The "/(a)/conf" and "/(b)/conf" routes conflict with each other
ooh yeah, this is a good point, will fix that |
Co-authored-by: Max Duval <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Copy all non-
sveltefiles to output directory.Why?
Allows users to structure their files as like.
Also useful for things like
favicon.icowhich should be at the root (unless otherwise specified).