Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing matcher methods for themes to Java API #173

Merged

Conversation

TheHaf-at-FraunhoferIOSB
Copy link
Contributor

@TheHaf-at-FraunhoferIOSB TheHaf-at-FraunhoferIOSB commented May 8, 2024

The SearchSpecJ API is missing methods for matching themes (withThemes, withoutThemes). This PR adds the missing methods.

Fixes #172.

@mvysny mvysny self-requested a review May 8, 2024 06:39
@mvysny mvysny self-assigned this May 8, 2024
Copy link
Owner

@mvysny mvysny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mvysny mvysny merged commit 3c8192b into mvysny:master May 8, 2024
6 checks passed
@TheHaf-at-FraunhoferIOSB
Copy link
Contributor Author

That was fast. 😺 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchSpecJ seems to be missing theme-related matchers
2 participants