Releases/v1.4.4

## Improvements

* fix: dropped frames not reported (#74)



Co-authored-by: Emily Dixon <[email protected]>
Co-authored-by: GitHub <[email protected]>

Author: daytime-em

library/build.gradle

@@ -81,8 +81,5 @@ dependencies {
   testImplementation 'junit:junit:4.13.2'
   testImplementation 'androidx.test.ext:junit:1.2.1'
   testImplementation "io.mockk:mockk:1.13.9"
-  // hm, seems like they got rid of API 16 at some point, so we'd have to handle that.
-  //   Robolectric doesn't need updated for anything in particular tho, test deps aren't exported
-  //noinspection GradleDependency
-  testImplementation 'org.robolectric:robolectric:4.8.1'
+  testImplementation 'org.robolectric:robolectric:4.11.1'
 }

library/src/main/java/com/mux/stats/sdk/muxstats/MuxStateCollector.kt

@@ -135,6 +135,12 @@ open class MuxStateCollector(
    */
   @Suppress("MemberVisibilityCanBePrivate")
   var droppedFrames = 0
+    set(value) {
+      field = value
+      muxStats.setDroppedFramesCount(field.toLong())
+      // note - in the current implementation, we rely on a subsequent playback event to send this.
+      //  this is probably better, as we may not want to cause beacons while the device is struggling
+    }
 
   /**
    * The list of renditions currently available as part of an HLS, DASH, etc stream
@@ -360,6 +366,8 @@ open class MuxStateCollector(
   @Suppress("unused")
   fun incrementDroppedFrames(droppedFrames: Int) {
     this.droppedFrames += droppedFrames
+    // note - in the current implementation, we rely on a subsequent playback event to send this.
+    //  this is probably better, as we may not want to cause beacons while the device is struggling
   }
 
   /**
@@ -537,6 +545,8 @@ open class MuxStateCollector(
     firstFrameRenderedAtMillis = FIRST_FRAME_NOT_RENDERED
     playbackPositionMills = TIME_UNKNOWN
     allowedHeaders.clear()
+    droppedFrames = 0
+    muxStats.setDroppedFramesCount(0)
   }
 
   @JvmSynthetic

library/src/test/java/com/mux/core_android/AndroidDeviceTests.kt

@@ -17,7 +17,7 @@ import org.junit.Test
 import org.robolectric.annotation.Config
 
 @Config(
-  sdk = [Build.VERSION_CODES.JELLY_BEAN, Build.VERSION_CODES.M]
+  sdk = [Build.VERSION_CODES.KITKAT, Build.VERSION_CODES.M]
 )
 class AndroidDeviceTests : AbsRobolectricTest() {
 

library/src/test/java/com/mux/core_android/StateCollectorTests.kt

@@ -9,8 +9,11 @@ import com.mux.stats.sdk.muxstats.MuxPlayerState
 import com.mux.stats.sdk.muxstats.MuxStateCollector
 import com.mux.stats.sdk.muxstats.MuxStats
 import io.mockk.every
+import io.mockk.just
 import io.mockk.mockk
+import io.mockk.runs
 import io.mockk.slot
+import io.mockk.verify
 import org.junit.Assert.assertEquals
 import org.junit.Assert.assertNotEquals
 import org.junit.Before
@@ -293,4 +296,60 @@ class StateCollectorTests : AbsRobolectricTest() {
       stateCollector.muxPlayerState
     )
   }
+
+  @Test
+  fun testIncrementDroppedFrames() {
+    val incrementSlot = slot<Long>()
+    val mockMuxStats = mockk<MuxStats> {
+      // MuxStats has its own test for this so we can just mock it here
+      every { setDroppedFramesCount(capture(incrementSlot)) } just runs
+    }
+    stateCollector = MuxStateCollector(
+      muxStats = mockMuxStats,
+      dispatcher = FakeEventDispatcher(),
+    )
+
+    val randomFrames1 = (0..100).random()
+    val randomFrames2 = (0..100).random()
+    stateCollector.incrementDroppedFrames(randomFrames1)
+    stateCollector.incrementDroppedFrames(randomFrames2)
+
+    verify {
+      mockMuxStats.setDroppedFramesCount(randomFrames1.toLong())
+      mockMuxStats.setDroppedFramesCount(randomFrames2 + randomFrames1.toLong())
+    }
+    
+    stateCollector.resetState()
+    verify {
+      mockMuxStats.setDroppedFramesCount(0)
+    }
+  }
+
+  @Test
+  fun testSetDroppedFrames() {
+    val incrementSlot = slot<Long>()
+    val mockMuxStats = mockk<MuxStats> {
+      // MuxStats has its own test for this so we can just mock it here
+      every { setDroppedFramesCount(capture(incrementSlot)) } just runs
+    }
+    stateCollector = MuxStateCollector(
+      muxStats = mockMuxStats,
+      dispatcher = FakeEventDispatcher(),
+    )
+
+    val randomFrames1 = (0..100).random()
+    val randomFrames2 = (0..100).random()
+    stateCollector.droppedFrames = randomFrames1
+    stateCollector.droppedFrames = randomFrames2
+
+    verify {
+      mockMuxStats.setDroppedFramesCount(randomFrames1.toLong())
+      mockMuxStats.setDroppedFramesCount(randomFrames2.toLong())
+    }
+
+    stateCollector.resetState()
+    verify {
+      mockMuxStats.setDroppedFramesCount(0)
+    }
+  }
 }