-
Notifications
You must be signed in to change notification settings - Fork 45
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purpose of Arc in Multiaddr #90
Comments
I believe the idea is that it is cheap to clone. The |
I've made pull request #89 to preserve the cheap clone while making the semantics clearer and improving (hopefully, still benchmarking) efficiency by using an |
i was searching for why
Arc
was used after my overnight test shown additional allocation tracing back to theArc
inMultiaddr
(probably unrelated, though it did catch my eye). The previous commit that made the change did not mention the reason for using it, and looking over the code, removing theArc
should work just fine and without being a breaking change.The text was updated successfully, but these errors were encountered: