Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix light/dark mode & RTL change speed regression #44534

Open
oliviertassinari opened this issue Nov 24, 2024 · 0 comments
Open
Labels
bug 🐛 Something doesn't work performance priority: important This change can make a difference regression A bug, but worse scope: docs-infra Specific to the docs-infra product status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 24, 2024

Steps to reproduce

The light/dark mode and RTL toggle is today x4 slower than what good enough is at in production, and the RTL/LTR toggle in dev mode is x5-50 slower than what good enough is at. It used to be ok:

v4.12.4 - Dev: mode ~600ms, RTL: ~600ms, Prod: mode and RTL ~150ms

v4 dark

v5.0.6 - Dev: mode ~1,369ms, RTL, ~10,865ms, Prod: mode and RTL ~200ms

v6.1.8 - Dev: mode ~2,253ms, RTL ~ 59,761ms, Prod: mode and RTL ~800ms

Material UI doesn't feel like a credible option for developers with this performance.

Context

Same problem as #41117. Material UI is not usable like this, not truly. I mean, as a developer, this reinforces this story: I would only adopt Material UI for a new React project so that I can then contribute a fix to this. Otherwise, I wouldn't want to touch Material UI, there are better options out there nowadays, and it would only make sense to use the rich components of MUI anytime I can't find anything better.

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: -

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work performance priority: important This change can make a difference status: waiting for maintainer These issues haven't been looked at yet by a maintainer regression A bug, but worse scope: docs-infra Specific to the docs-infra product labels Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work performance priority: important This change can make a difference regression A bug, but worse scope: docs-infra Specific to the docs-infra product status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Development

No branches or pull requests

1 participant