-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a configurable title-regex
#345
Comments
Hi @hofbi thanks for the feature request! Could you describe in a little more detail what you mean (e.g. examples of a regex you might use, and titles it would and would not match). |
For instance, if I want to have both an ticket id and the conventional commit pattern in the title such as Right now, I found a workaround by using https://github.com/thehanimo/pr-title-checker for checking the title and this action for the body. Since you already allow for specifying a regex for the body, I thought it might be useful to have this customization option for the title as well. If the |
@hofbi I had a feeling that might be the use case! Where I work, we use conventional commits with a ticket ID at the end of the title, so more like Would you be interested in creating PR for this feature? |
I see, then it is probably difficult to provide a custom pattern. An alternative option that could keep the conventional commit check would be to add for instance a Nevermind, I just created this issue because I thought it would be easy to add. Simple workaround is just to combine this action with https://github.com/thehanimo/pr-title-checker. So if you don't want to touch the title checking, we can close this. |
Is your feature request related to a problem? Please describe.
I would like to have a configurable regex for the PR title
Describe the solution you'd like
Add a
title-regex
option similar to thebody-regex
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: