Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsgFlo coordinator crashes if ignored participant doesn't send discovery message #133

Open
bergie opened this issue May 12, 2017 · 0 comments

Comments

@bergie
Copy link
Member

bergie commented May 12, 2017

With MsgFlo coordinator we have two ways to have processes appear in the graph:

  • Started by MsgFlo coordinator itself
  • --ignored and assumed to be running somewhere and sending its own discovery messages

At start-up MsgFlo waits until each participant has been discovered and its connections set up correctly. Like with #94 if one participant doesn't send a discovery message in this behavior, MsgFlo coordinator fails with an error:

May 12 01:42:30 c-flo node[6216]: Error: Waiting for participant siri timed out
May 12 01:42:30 c-flo node[6216]:     at Timeout._onTimeout (/opt/c-flo/node_modules/msgflo/src/coordinator.coffee:74:21)
May 12 01:42:30 c-flo node[6216]:     at ontimeout (timers.js:380:14)

Instead, MsgFlo should be aware of what nodes/edges in the graph are "real", and what are "pending", and allow itself to start promptly, and then bind queues as participants appear (#127).

This is especially critical for setups like c-flo where many participants do get shut down at night.

Initially reported at c-base/mqttwebview#2

bergie added a commit to c-base/c-flo that referenced this issue May 16, 2017
@bergie bergie changed the title MsgFlo coordinator fails to start if ignored participant doesn't send discovery message MsgFlo coordinator crashes if ignored participant doesn't send discovery message May 30, 2017
jonnor added a commit to bitraf/bitraf-iot that referenced this issue May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant