Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandora has stopped working #120

Open
kevindb opened this issue Jun 26, 2017 · 7 comments
Open

Pandora has stopped working #120

kevindb opened this issue Jun 26, 2017 · 7 comments

Comments

@kevindb
Copy link

kevindb commented Jun 26, 2017

Media Keys recently stopped working with pandora.com. It simply always reports "There's nothing playing right now" (see attached screenshot). The timeline seems like it would fit the June 20 release of 4.60.
If there's anything else I can do to help, such as providing logs or testing, just let me know.
Thank you for a wonderful extension!

screen shot 2017-06-26 at 7 57 59 am

@RadValentin
Copy link
Contributor

@kevindb The way the plugin works is by looking for page elements with certain CSS classes and clicks them to play/pause/etc. Can you check that the classes defined here match the playback buttons in Pandora.

@kevindb
Copy link
Author

kevindb commented Jul 11, 2017

The class names in the second section (starting on line 25) are correct. However, I suspect the isPlaying section is outdated.
If I understand your code, Line 49 is looking for a string "#ic_pause". When I inspect the svg, the xlink:href does not contain the string "#ic_pause".

This is what it looks like when music IS playing:
screen shot playing

This is when the music IS NOT playing:
screen shot paused

Could this be the cause of the issue?

@RadValentin
Copy link
Contributor

Yep, most likely, you'd need to check the aria attribute aria-labelledby to determine the play/pause state.

@kevindb
Copy link
Author

kevindb commented Jul 14, 2017

If you wanted to continue using the attribute xlink:href, you could look for the string #controls_pause or #controls_play instead of the current #ic_pause.

@kevindb
Copy link
Author

kevindb commented Jul 31, 2017

I just that extension v4.61 is working with Pandora. Thank you!

@kevindb
Copy link
Author

kevindb commented Aug 2, 2017

I spoke too soon. The extension has not been working with Pandora for the last two days.

@kevindb
Copy link
Author

kevindb commented Aug 8, 2017

Could we reopen this issue, please? Pandora has stopped working, with the same behavior as I originally described.

@msfeldstein msfeldstein reopened this Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants