-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing an attribute of a geometry instanced by another new attribute with a superior length break the renderer #30168
Comments
maybe @RenaudRohlinger knows about it ? |
Ah yes, it's because the instance node is created when the material is first mounted, you need to add |
Here is the updated fiddle with material.needsUpdate = true Does not seem to work : |
oops didn't see my console, indeed, then we need to fix this in |
@RenaudRohlinger This is a blocking bug on my end, can I help with this ? Where should I look at exactly ? |
Description
On previous version of Three.JS, ( r162 havnt tested between then and now ) ,we were able to replace an entire instancedgeometry attribute with a new length and set the instanceCount to a superior value
This is a valuable feature for performances if you play with huge dynamic instanced geometry that increments count over time and allows to first allocate a smaller buffer then grow with a safe multiple to limit the size of the buffer
But this also limits flexibility of building geometries by a lot
In both WebGL and WebGPU back end it now breaks the renderer :
Look at the switchArray function
Live example
The text was updated successfully, but these errors were encountered: