use format specifiers to create names

[mathause]

Format specifiers are not taken into account when creating names:

import filefinder

f = filefinder.FileFinder(
    path_pattern="",
    file_pattern="domain_{domain:02d}.nc",
)

domain = 1

print(f.create_full_name(domain=domain))
print(f"domain_{domain:02d}.nc")

domain_1.nc
domain_01.nc

Because the _pattern_no_fmt_spec is used:

https://github.com/mathause/filefinder/blob/729c8eeddab6f37c989f5af3d2750f64b4638b65/filefinder/_filefinder.py#L52

In this case it would be good if the fmt spec was used. But does that hold in general?

[mathause]

There are specifier that parse can parse but that are not valid format options (e.g. "{char:l}". See

• https://github.com/r1chardj0n3s/parse#format-specification
• https://docs.python.org/3/library/string.html#format-specification-mini-language

[mathause]

What we could do is to support a subset of the format specifiers for creating file names. Honestly the only one that is probably relevant is d? Maybe f. (Note that parse seems to ignores the width specifier...)

@veni-vidi-vici-dormivi

[veni-vidi-vici-dormivi]

Yes I agree, only d or n (yeah maybe f) make sense.